Skip to content

Added Binary Search Topic #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 10, 2024
Merged

Added Binary Search Topic #909

merged 8 commits into from
Jun 10, 2024

Conversation

SadafKausar2025
Copy link
Contributor

Related Issue #859

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

Description

[Please include a brief description of the changes or features added]

Type of PR

  • Documentation update

Screenshot (1968)

Recording.2024-06-10.083704.mp4

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

@SadafKausar2025
Copy link
Contributor Author

hello @ajay-dhangar
can you please review this PR?

github-actions[bot]
github-actions bot reviewed Jun 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SadafKausar2025! 🎉 Thank you for submitting your pull request to CodeHarborHub. We appreciate your contribution and enthusiasm! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out. Thanks for contributing!

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jun 10, 2024 •
edited
Loading

Here's the code health analysis summary for commits 1b2fca5..6dc95df. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation good first issue Good for newcomers GSSOC'24 GirlScript Summer of Code | Contributor gssoc GirlScript Summer of Code | Contributor labels Jun 10, 2024
@ajay-dhangar ajay-dhangar linked an issue Jun 10, 2024 that may be closed by this pull request
[Feature Request]: Adding Binary search after Array Topic #859
Closed
4 tasks
@SadafKausar2025
Copy link
Contributor Author

Hello @ajay-dhangar
Is this PR all Ok and set?

ajay-dhangar
ajay-dhangar requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now update your code based on suggestions

@SadafKausar2025
Copy link
Contributor Author

Ok

@SadafKausar2025
Copy link
Contributor Author

hello @ajay-dhangar
can you see this I have corrected the code

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ajay-dhangar
ajay-dhangar approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added some code, but next time, please focus on our structure for best practices.

@ajay-dhangar ajay-dhangar merged commit 781e9e9 into codeharborhub:main Jun 10, 2024
5 checks passed
@SadafKausar2025
Copy link
Contributor Author

hello @ajay-dhangar
you have merged but not given level

@SadafKausar2025
Copy link
Contributor Author

Done. I added some code, but next time, please focus on our structure for best practices.

sure, I will
I understood when I see you updated code

@SadafKausar2025
Copy link
Contributor Author

@ajay-dhangar please give level also

@ajay-dhangar ajay-dhangar added the level2 GirlScript Summer of Code | Contributor's Levels label Jun 10, 2024
@sanjay-kv sanjay-kv added level1 GirlScript Summer of Code | Contributor's Levels and removed level2 GirlScript Summer of Code | Contributor's Levels labels Jun 16, 2024
@ajay-dhangar
Copy link
Member

@sanjay-kv thanks,

@sanjay-kv sanjay-kv removed the level1 GirlScript Summer of Code | Contributor's Levels label Jun 20, 2024
@ajay-dhangar ajay-dhangar added level1 GirlScript Summer of Code | Contributor's Levels and removed level1 GirlScript Summer of Code | Contributor's Levels labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@SadafKausar2025 SadafKausar2025

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor
Projects
@CodeHarborHub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding Binary search after Array Topic
3 participants
@SadafKausar2025 @ajay-dhangar @sanjay-kv